Hotfix/setup aesthetics #28

Open
inv3ntor01 wants to merge 4 commits from hotfix/setup-aesthetics into main
inv3ntor01 commented 2026-07-03 01:30:01 +00:00 (Migrated from github.com)

Summary

Refactored SetupCommand aesthetics to use Laravel Prompts (note(), password(), named arguments) and the laraKube* badge methods consistently throughout the Docker installation flow. Removed the old sh* style from the Docker step and made distro detection universal.

Changes

app/Traits/LaraKubeOutput.php

  • Removed laraKubeSuccess() (unused after switching to laraKubeInfo for success messages)

app/Commands/SetupCommand.php

  • Laravel Prompts conventions — all confirm() calls now use label: named argument
  • Sudo authentication — replaced passthru('sudo -v') with password() from Laravel Prompts, piped to sudo -S with exit code validation
  • Universal distro detection — removed the hard block on non-Ubuntu/Debian:
    • apt-based (Debian, Ubuntu, Mint, Pop, etc.): detailed step-by-step install (kept)
    • all other distros (Fedora, CentOS, RHEL, Arch, openSUSE, etc.): falls back to Docker's get.docker.com convenience script
  • Progress bar — replaced $this->shRunSteps() with Symfony Console's createProgressBar() in blue
  • Badge style — all shInfo/shWarn/shSuccess/shError calls in the Docker flow replaced with laraKubeInfo/laraKubeWarn/laraKubeError (blue badge style)
  • note() for headers — replaced $this->shHeader() and $this->shFooter() with note() from Laravel Prompts
  • note() for group messages — replaced manual $this->line() blocks with note() for the docker group instructions

app/Traits/InstallsK9s.php

  • Consistent output — replaced $this->warn() with $this->laraKubeWarn()
## Summary Refactored `SetupCommand` aesthetics to use Laravel Prompts (`note()`, `password()`, named arguments) and the `laraKube*` badge methods consistently throughout the Docker installation flow. Removed the old `sh*` style from the Docker step and made distro detection universal. ### Changes #### `app/Traits/LaraKubeOutput.php` - **Removed** `laraKubeSuccess()` (unused after switching to `laraKubeInfo` for success messages) #### `app/Commands/SetupCommand.php` - **Laravel Prompts conventions** — all `confirm()` calls now use `label:` named argument - **Sudo authentication** — replaced `passthru('sudo -v')` with `password()` from Laravel Prompts, piped to `sudo -S` with exit code validation - **Universal distro detection** — removed the hard block on non-Ubuntu/Debian: - **apt-based** (Debian, Ubuntu, Mint, Pop, etc.): detailed step-by-step install (kept) - **all other distros** (Fedora, CentOS, RHEL, Arch, openSUSE, etc.): falls back to Docker's `get.docker.com` convenience script - **Progress bar** — replaced `$this->shRunSteps()` with Symfony Console's `createProgressBar()` in blue - **Badge style** — all `shInfo`/`shWarn`/`shSuccess`/`shError` calls in the Docker flow replaced with `laraKubeInfo`/`laraKubeWarn`/`laraKubeError` (blue badge style) - **`note()` for headers** — replaced `$this->shHeader()` and `$this->shFooter()` with `note()` from Laravel Prompts - **`note()` for group messages** — replaced manual `$this->line()` blocks with `note()` for the docker group instructions #### `app/Traits/InstallsK9s.php` - **Consistent output** — replaced `$this->warn()` with `$this->laraKubeWarn()`
This pull request has changes conflicting with the target branch.
  • app/Commands/SetupCommand.php
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hotfix/setup-aesthetics:hotfix/setup-aesthetics
git switch hotfix/setup-aesthetics

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff hotfix/setup-aesthetics
git switch hotfix/setup-aesthetics
git rebase main
git switch main
git merge --ff-only hotfix/setup-aesthetics
git switch hotfix/setup-aesthetics
git rebase main
git switch main
git merge --no-ff hotfix/setup-aesthetics
git switch main
git merge --squash hotfix/setup-aesthetics
git switch main
git merge --ff-only hotfix/setup-aesthetics
git switch main
git merge hotfix/setup-aesthetics
git push origin main
Sign in to join this conversation.
No description provided.